Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike compilation errors do not exit 0 #99

Open
aegaas opened this issue Jul 30, 2018 · 1 comment
Open

spike compilation errors do not exit 0 #99

aegaas opened this issue Jul 30, 2018 · 1 comment

Comments

@aegaas
Copy link

aegaas commented Jul 30, 2018

exiting non-zero is a common unix convention that allows for scripted pipelines to work properly.

For instance, on our production app we've discovered that our pipeline improperly destroyed a site when a build error occurred when our upstream data provider's payload changed, thus destroying the site.

Can we get an exit code on compile error so the rest of the build pipeline fails instead of blank sites are instead getting deployed or additional scripting checks are needed to work around this?

@jescalan
Copy link
Member

Sure! Interested in contributing this fix? It should be quite easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants