Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating paginated results isn't working properly #149

Open
simonhamp opened this issue Sep 7, 2023 · 2 comments · May be fixed by #152
Open

Generating paginated results isn't working properly #149

simonhamp opened this issue Sep 7, 2023 · 2 comments · May be fixed by #152
Labels
bug Something isn't working

Comments

@simonhamp
Copy link
Contributor

I'm using the latest version that has #140 in it. I've updated my config.

The pagination is detecting that it needs to run 👍🏼

But every page generated only has the data for Page 1
@simonhamp
Copy link
Contributor Author

simonhamp commented Sep 7, 2023 •
edited
Loading

@jesseleite It seems to have something to do with cloning the $page object inside writePaginatedPages - when I stop that cloning, it works just fine (but I haven't run the tests yet)

@tao
Copy link
Contributor

tao commented Sep 12, 2023

The update also broke pagination on my website. It would happen randomly so pages 1-7 worked and 8 didn't work, then 9-10 worked again.

I had to revert back to v2.0.0.

@simonhamp simonhamp linked a pull request Sep 28, 2023 that will close this issue
Open
@duncanmcclean duncanmcclean added the bug Something isn't working label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop cloning page simonhamp/ssg
3 participants
@simonhamp @tao @duncanmcclean