Add webdriver_extended.py, refactor

Author: startrug

config.json

@@ -1,6 +1,6 @@
 {
-  "browser": "firefox",
-  "headless_mode": true,
-  "tested_page": "http://www.phptravels.net/",
+  "browser": "chrome",
+  "headless_mode": false,
+  "base_url": "http://www.phptravels.net/",
   "timeout": 10
 }

extensions/webdriver_extended.py

@@ -0,0 +1,10 @@
+from selenium.webdriver.support.event_firing_webdriver import EventFiringWebDriver
+
+
+class WebDriverExtended(EventFiringWebDriver):
+    def __init__(self, driver, event_listener, config):
+        super().__init__(driver, event_listener)
+        self.base_url = config["base_url"]
+
+    def open(self):
+        self.get(self.base_url)

pages/base_page.py

@@ -2,5 +2,5 @@ class BasePage:
     def __init__(self, driver):
         self.driver = driver
 
-    def open_home_page(self, config):
-        self.driver.get(config["tested_page"])
+    def open(self):
+        self.driver.open()

tests/conftest.py

@@ -9,7 +9,7 @@
 CONFIG_PATH = "../config.json"
 DEFAULT_WAIT_TIME = 10
 SUPPORTED_BROWSERS = ["chrome", "firefox", "edge"]
-DEFAULT_WEBSITE = "http://www.google.com/"
+DEFAULT_URL = "http://www.google.com/"
 
 
 @pytest.fixture(scope='session')
@@ -33,13 +33,13 @@ def wait_time_setup(config):
 
 
 @pytest.fixture(scope='session')
-def website_setup(config):
-    return config['tested_page'] if 'tested_page' in config else DEFAULT_WEBSITE
+def url_setup(config):
+    return config["base_url"] if "base_url" in config else DEFAULT_URL
 
 
 @pytest.fixture()
 def setup(request, config):
-    driver = DriverFactory.get_driver(config["browser"], config["headless_mode"])
+    driver = DriverFactory.get_driver(config)
     driver.implicitly_wait(config["timeout"])
     request.cls.driver = driver
     before_failed = request.session.testsfailed

tests/test_log_in.py

@@ -4,14 +4,14 @@
 from pages.login_page import LogInPage
 
 
-@pytest.mark.usefixtures("setup", "website_setup")
+@pytest.mark.usefixtures("setup")
 class TestLogIn:
 
     @allure.title("Login with valid data test")
     @allure.description("This is test of login with valid data")
-    def test_login_passed(self, config):
+    def test_login_passed(self):
         log_in_page = LogInPage(self.driver)
-        log_in_page.open_home_page(config)
+        log_in_page.open()
         log_in_page.expand_account_menu()
         log_in_page.open_login_page()
         log_in_page.set_user_inputs("[email protected]", "demouser")
@@ -22,9 +22,9 @@ def test_login_passed(self, config):
 
     @allure.title("Login with invalid email test")
     @allure.description("This is test of login with invalid email")
-    def test_login_failed(self, config):
+    def test_login_failed(self,):
         log_in_page = LogInPage(self.driver)
-        log_in_page.open_home_page(config)
+        log_in_page.open()
         log_in_page.expand_account_menu()
         log_in_page.open_login_page()
         log_in_page.set_user_inputs("[email protected]", "demouser")

utils/driver_factory.py

@@ -1,43 +1,43 @@
 from selenium import webdriver
-from selenium.webdriver.support.event_firing_webdriver import EventFiringWebDriver
 from webdriver_manager.chrome import ChromeDriverManager
 from webdriver_manager.firefox import GeckoDriverManager
 from webdriver_manager.microsoft import EdgeChromiumDriverManager
 from helpers.web_driver_listener import WebDriverListener
 from msedge.selenium_tools import EdgeOptions, Edge
+from extensions.webdriver_extended import WebDriverExtended
 
 
 class DriverFactory:
     @staticmethod
-    def get_driver(browser, headless_mode=False) -> EventFiringWebDriver:
-        if browser == "chrome":
+    def get_driver(config) -> WebDriverExtended:
+        if config["browser"] == "chrome":
             options = webdriver.ChromeOptions()
             options.add_argument("start-maximized")
-            if headless_mode is True:
+            if config["headless_mode"] is True:
                 options.add_argument("--headless")
-            driver = EventFiringWebDriver(
+            driver = WebDriverExtended(
                 webdriver.Chrome(ChromeDriverManager().install(), options=options),
-                WebDriverListener()
+                WebDriverListener(), config
             )
             return driver
-        elif browser == "firefox":
+        elif config["browser"] == "firefox":
             options = webdriver.FirefoxOptions()
-            if headless_mode is True:
+            if config["headless_mode"] is True:
                 options.headless = True
-            driver = EventFiringWebDriver(
+            driver = WebDriverExtended(
                 webdriver.Firefox(executable_path=GeckoDriverManager().install(), options=options),
-                WebDriverListener()
+                WebDriverListener(), config
             )
             return driver
-        elif browser == "edge":
+        elif config["browser"] == "edge":
             options = EdgeOptions()
             options.use_chromium = True
-            if headless_mode is True:
+            if config["headless_mode"] is True:
                 options.headless = True
             driver_path = EdgeChromiumDriverManager().install()
-            driver = EventFiringWebDriver(
+            driver = WebDriverExtended(
                 Edge(executable_path=driver_path, options=options),
-                WebDriverListener()
+                WebDriverListener(), config
             )
             return driver
         raise Exception("Provide valid driver name")