Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm retry behaviour when a WriteTimeoutException occurs for Collections #1771

Open
amorton opened this issue Dec 1, 2024 · 1 comment
Labels
Bug Something isn't working Feature - Collections Issue impacts users of Collections To-Do

Comments

@amorton
Copy link
Contributor

amorton commented Dec 1, 2024

we worked out that the WritetimeoutException is coming back as a WriteType SIMPLE when it fails in the COMMIT phase of the Paxos Tx for collections. We are confirming this with extra logging, if true the retry for collections should work for any write timeout (so not need to check the write type).

Original desc is below...


Confirm what happens in the API when running a write operation for a Collection and a WriteTimeoutException is returned from the DB.

It may be returning the timeout to the client without retrying, we should review if this is the best and if we can retry the request

@amorton amorton added Bug Something isn't working Feature - Collections Issue impacts users of Collections To-Do labels Dec 11, 2024
@amorton
Copy link
Contributor Author

amorton commented Dec 11, 2024

discussions - also check what retry policy the tables are using. It would be good to have the same retry policy is possible, which would mean removing the test for the write type.

note - we also discussed refactoring the try policy class so:

  • derives from DefaultRetryPolicy
  • does not override default methods from the RetryPolicy interface
  • has better logging that always logs the decisions, and maybe logs a rethrow decision at WARN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feature - Collections Issue impacts users of Collections To-Do
Projects
None yet
Development

No branches or pull requests

1 participant