StiCA option defined twice in StRoot/StBFChain/BigFullChain.h

[plexoos]

star-sw/StRoot/StBFChain/BigFullChain.h

Line 1717 in 05ba039

{"StiCA" ,"Sti","","Sti","StiMaker","TPCCATracker,StiCA" ,"StiCA tracker",kFALSE},

star-sw/StRoot/StBFChain/BigFullChain.h

Lines 1719 to 1720 in 05ba039

	{"StiCA" ,"Sti","","Sti,StiLib,StiCALib,StiLibs,SCL,StEvent,StDbT,TpcIT,compend,tbutil","StiMaker"
	, "StEventUtilities,libEG,StiUtilities,StiMaker","Sti+CA tracker",kFALSE},

[genevb]

Hm. Introduced by Victor in 2016:
commit 275cd0f
or
https://www.star.bnl.gov/cgi-bin/protected/viewvc.cgi/cvsroot/StRoot/StBFChain/BigFullChain.h?r1=1.257&r2=1.258
with the message:
"Pure Sti does not load StiCA++ libraries"

...not quite obvious :-/

[genevb]

There was also a tweak of the original StiCA option a few months before that by @plexoos . I'm not certain it's relevant, but adding it here in case it helps spur memories....
commit 84a7ba4

[plexoos]

I checked the logs, and it seems to me that the second definition is not used and can thus be removed

[genevb]

Thanks, Dmitri.... Second? As in the second one introduced in time into the code, or the second one in the order of the written code?

…

-Gene

On Nov 14, 2023, at 4:17 PM, Dmitri Smirnov ***@***.***> wrote: I checked the logs, and it seems to me that the second definition is not used and can thus be removed

[plexoos]

I mean 'second' as in the order they appear in BigFullChain.h, specifically, the definition on line 1719. I don't believe options with the same name can overwrite each other or merge in any way. Perhaps, the logic is to stop scanning once an option with the desired name is found.

In the logs, it appears that only 'Sti' is being turned on by 'StiCA,' which is consistent with the first definition.

[fgeurts]

Has this second occurrence been removed? From the looks of it, it is still there. Should it (line 1719) be removed to avoid any more confusion - and this issue to be closed?

[genevb]

There are still two definitions of "StiCA" in BigFullChain.h, so I think we have not yet resolved this. I expect Dmitri is correct that the second definition is unused, with the first one being the first found and thus always used.....so the second one can probably be removed. To-do.