Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StiCA option defined twice in StRoot/StBFChain/BigFullChain.h #629

Open
plexoos opened this issue Nov 14, 2023 · 7 comments
Open

StiCA option defined twice in StRoot/StBFChain/BigFullChain.h #629

plexoos opened this issue Nov 14, 2023 · 7 comments
Assignees

Comments

@plexoos
Copy link
Member

plexoos commented Nov 14, 2023

{"StiCA" ,"Sti","","Sti","StiMaker","TPCCATracker,StiCA" ,"StiCA tracker",kFALSE},

{"StiCA" ,"Sti","","Sti,StiLib,StiCALib,StiLibs,SCL,StEvent,StDbT,TpcIT,compend,tbutil","StiMaker"
, "StEventUtilities,libEG,StiUtilities,StiMaker","Sti+CA tracker",kFALSE},

@genevb
Copy link
Contributor

genevb commented Nov 14, 2023

Hm. Introduced by Victor in 2016:
commit 275cd0f
or
https://www.star.bnl.gov/cgi-bin/protected/viewvc.cgi/cvsroot/StRoot/StBFChain/BigFullChain.h?r1=1.257&r2=1.258
with the message:
"Pure Sti does not load StiCA++ libraries"

...not quite obvious :-/

@genevb
Copy link
Contributor

genevb commented Nov 14, 2023

There was also a tweak of the original StiCA option a few months before that by @plexoos . I'm not certain it's relevant, but adding it here in case it helps spur memories....
commit 84a7ba4

@plexoos
Copy link
Member Author

plexoos commented Nov 14, 2023

I checked the logs, and it seems to me that the second definition is not used and can thus be removed

@genevb
Copy link
Contributor

genevb commented Nov 14, 2023 via email

@plexoos
Copy link
Member Author

plexoos commented Nov 15, 2023

I mean 'second' as in the order they appear in BigFullChain.h, specifically, the definition on line 1719. I don't believe options with the same name can overwrite each other or merge in any way. Perhaps, the logic is to stop scanning once an option with the desired name is found.

In the logs, it appears that only 'Sti' is being turned on by 'StiCA,' which is consistent with the first definition.

@fgeurts
Copy link
Member

fgeurts commented May 24, 2024

Has this second occurrence been removed? From the looks of it, it is still there. Should it (line 1719) be removed to avoid any more confusion - and this issue to be closed?

@genevb
Copy link
Contributor

genevb commented May 28, 2024

There are still two definitions of "StiCA" in BigFullChain.h, so I think we have not yet resolved this. I expect Dmitri is correct that the second definition is unused, with the first one being the first found and thus always used.....so the second one can probably be removed. To-do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants