Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Warn or Error if Trying to Read to ArgOut in Accel #255

Open
mattfel1 opened this issue Jan 17, 2018 · 3 comments
Open

Warn or Error if Trying to Read to ArgOut in Accel #255

mattfel1 opened this issue Jan 17, 2018 · 3 comments

Comments

@mattfel1
Copy link
Member

Physically, we can do this. But shouldn't we throw an error since you should be using a HostIO and not an ArgOut? Currently it won't crash anywhere until chisel compilation

@dkoeplin
Copy link
Collaborator

I agree its a bit weird, but by convention so far, ArgOut is just a register that the host can access after Accel executes. HostIO is one that it can access during Accel execution. Effectively that means Accel can do whatever it wants for both ArgOut and HostIO, only the host is limited.

@mattfel1
Copy link
Member Author

Ok I'll correct the codegen and check it inside one of the other unit tests

mattfel1 added a commit that referenced this issue Jan 20, 2018
…metadata, fix missing method for %-% in Utils, fix regression statistics reporter
@mattfel1
Copy link
Member Author

mattfel1 commented Feb 7, 2018

There may be an issue when you have a read and write to an argout that is unrolled into multiple parallel accesses. Look into this

@mattfel1 mattfel1 reopened this Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants