Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing logger implementation #166

Open
makaimann opened this issue Jan 4, 2021 · 0 comments
Open

Consider changing logger implementation #166

makaimann opened this issue Jan 4, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@makaimann
Copy link
Collaborator

A few reasons to change the logger implementation:

  • it seems like the logger evaluates all the arguments regardless of the verbosity (e.g. even if it doesn't print it). This means the to_string for large terms could be called all the time even at low verbosity.
  • I believe it is the only part of the codebase that uses C++17

Could consider looking into a stream based one -- maybe that would help. A macro could also work, but we do want to be able to change the verbosity dynamically so it would have to take an argument.

@makaimann makaimann added the enhancement New feature or request label Jan 4, 2021
@makaimann makaimann self-assigned this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant