Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementwise versions of unary functions #347

Closed
12 tasks done
bob-carpenter opened this issue Aug 14, 2016 · 5 comments
Closed
12 tasks done

elementwise versions of unary functions #347

bob-carpenter opened this issue Aug 14, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@bob-carpenter
Copy link
Contributor

bob-carpenter commented Aug 14, 2016

Summary:

There are functions like log2() and log1p() that are still not vectorized for elementwise application to containers.

Description:

All of our unary functions should be vectorized. Review the index of the manual and make sure every unary function is vectorized. Here are the ones for this issue:

  • acosh
  • asinh
  • atanh
  • exp2
  • log1m_inv_logit
  • log1p
  • log2
  • log_inv_logit
  • logit
  • Phi_approx
  • trigamma
  • trunc

Current Version:

v2.11.0

@bob-carpenter bob-carpenter added this to the v2.11.0++ milestone Aug 14, 2016
@bob-carpenter
Copy link
Contributor Author

bob-carpenter commented Aug 18, 2016

See #202, which was only partially completed.

@bob-carpenter
Copy link
Contributor Author

See also #272 for logit() and #271 for log1m_inv_logit

@bob-carpenter bob-carpenter modified the milestones: Future, v2.11.0++, v3.0.0 Aug 18, 2016
@bob-carpenter
Copy link
Contributor Author

This was blocked before due to ambiguous functions. It's fixed with a judicious application of namespace qualifications and Boost enable_if and disable_if qualifications. Now that I have log1p working I should be able to knock off the rest in no time. It will not require reverse-mode specializations as suggested in #272 and #271 (now closed).

@bob-carpenter bob-carpenter modified the milestones: v2.11.0++, v3.0.0 Aug 28, 2016
@bob-carpenter bob-carpenter changed the title vectorizing remaining unary functions elementwise versions of unary functions Aug 29, 2016
@syclik syclik modified the milestones: v2.12.0, v2.12.0++ Sep 7, 2016
@syclik syclik closed this as completed in 45bc548 Oct 16, 2016
@MatsuuraKentaro
Copy link

Stan manual v2.17 says pow is not vectorized yet. Do you have a plan?

@bob-carpenter
Copy link
Contributor Author

bob-carpenter commented Oct 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants