Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy/move rhat() and neff_ratio() to rstan(arm)? #119

Closed
strengejacke opened this issue Sep 27, 2017 · 5 comments
Closed

copy/move rhat() and neff_ratio() to rstan(arm)? #119

strengejacke opened this issue Sep 27, 2017 · 5 comments

Comments

@strengejacke
Copy link

I was looking for functions to extract rhat and the ratio for number of effective samples, and found those in the brms-package for brmsfit-objects, but not in rstan or rstanarm for stanreg-objects (where I would expect those functions to be).

Instead, I later realized that these are in the bayesplot-pkg. Wouldn't it make more sense to have the functions (also) in rstan/rstanarm as well?

@tjmahr
Copy link
Collaborator

tjmahr commented Sep 27, 2017

@jgabry would the generics go in rstantools and the S3 methods go into rstan and rstanarm? I'm not sure about the stanverse organization in this regard.

@jgabry
Copy link
Member

jgabry commented Apr 22, 2018

Circling back through old issues. Yes I think having these as rstantools generics makes the most sense. I’ll open an issue for it over there.

Sent with GitHawk

@jgabry
Copy link
Member

jgabry commented Apr 22, 2018

stan-dev/rstantools#31

Sent with GitHawk

@avehtari
Copy link
Contributor

I think these are now in posterior. Maybe this issue can be closed?

@strengejacke
Copy link
Author

Yes, I think so, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants