Draft: Overly restricted/constrained lifetimes #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some places take in
&'x self
when they shouldn't.The functions returning iterators, probably need two lifetimes, so that they don't bind the lifetime associated with the input buffer, to self.
But I need a bit more time to play with the code.
Discussion in the discord forums is telling me that some functions, like this one:
Could maybe return an
Option<Cow<'_, Cow<'x, str>>>
Which looks a little crazy to me tbh, but i'm told: