Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a annotation flag to trigger rollout on change of cm/secrets #771

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding a annotation flag to trigger rollout on change of cm/secrets #771

wants to merge 3 commits into from

Conversation

wololowarrior
Copy link

@wololowarrior wololowarrior commented Oct 16, 2024 •
edited
Loading

Fixes #773

#724 This pr removed the functionality of triggering a rollout strategy on change of configmap/secrets.
But there are some cases when we want to trigger a rollout instead of just restarting the pod.

As part of this pr,

  1. Adding a new annotation reloader.stakater.com/triggerRollout if set to true will trigger a rollout strategy for that rollout. The default can be unset or false, so current behaviour should continue on.

Example
Setting as true

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: simple-rollout
  annotations:
    reloader.stakater.com/auto: "true"
    reloader.stakater.com/triggerRollout: "true"
spec:
  replicas: 2

@wololowarrior
Copy link
Author

@MuneebAijaz Can i get some maintainers reviews?

@wololowarrior
Copy link
Author

wololowarrior commented Nov 2, 2024 •
edited
Loading

@MuneebAijaz @karl-johan-grahn Would appreciate 👀 and reviews on this whenever possible!

@karl-johan-grahn
Copy link
Contributor

@wololowarrior can you please add a unit test for this? You can take inspiration from existing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCE]Support triggering a rollout strategy or current behaviour of pod restart on change.
2 participants
@wololowarrior @karl-johan-grahn