Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] RejectReason should be combined with RejectCode with proper backwards compatibility implementation #5843

Open
jferrant opened this issue Feb 18, 2025 · 0 comments

Comments

@jferrant
Copy link
Collaborator

Unfortunately in order to enable expanding RejectCode values without breaking backwards compatibility, #5827 added RejectReason to the BlockResponseData struct.

As part of the next hardfork, remove this add a proper RejectCode::Unknown(u8) which will enable proper backwards compatibilty and move all the RejectReasons to RejectCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant