Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move crate versioning to top-level Cargo.toml #4105

Open
jbencin opened this issue Nov 29, 2023 · 0 comments
Open

Move crate versioning to top-level Cargo.toml #4105

jbencin opened this issue Nov 29, 2023 · 0 comments
Assignees

Comments

@jbencin
Copy link
Contributor

jbencin commented Nov 29, 2023

Recently I tried updating wsts and found that it failed to compile if not all workspace members used the same version of the crate. I fixed it by setting a common version for all workspace members in the top-level Cargo.toml file:

[workspace.dependencies]  
wsts = "5.0"

And in the workspace member Cargo.toml files:

[dependencies]
wsts = {workspace = true}

There are several crates that are used in multiple workspace members, and using different versions of them could lead to build or runtime errors. Most (all?) of these crates should be moved to the [workspace.dependencies] section

@jbencin jbencin self-assigned this Nov 29, 2023
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant