Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine-grained allow/deny modes for post-conditions #2557

Open
friedger opened this issue Mar 31, 2021 · 3 comments
Open

More fine-grained allow/deny modes for post-conditions #2557

friedger opened this issue Mar 31, 2021 · 3 comments
Assignees
Labels
clarity consensus-critical icebox Issues that are not being worked on

Comments

@friedger
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, users have to specify post-conditions for transactions that transfer assets from a contract. Users do not care about whether a contract is losing/transferring any assets.

Describe the solution you'd like
Only verify post-conditions that affect the tx-sender

Additional context
leather-io/extension#969

@jcnelson
Copy link
Member

jcnelson commented Apr 2, 2021

Hi @friedger, this is something the wallet should be doing for the user. I think there needs to be an API endpoint on the node that does the following:

This way, the wallet can run the contract-call, get the AssetMap, generate the post-conditions, and present them to the user to confirm that the assets that are moving are all desired.

@jcnelson jcnelson changed the title Remove requirements for contract post conditions More fine-grained allow/deny modes for post-conditions Apr 5, 2021
@jcnelson
Copy link
Member

jcnelson commented Apr 5, 2021

I renamed this issue to call for a re-assessment of the post-condition allow/deny modes, so that a user can, for example, execute a deny-mode transaction only on their own tokens, but allow-mode on other principals' tokens.

@jcnelson
Copy link
Member

Transferring this issue to @obycode for the time being. Please feel free to re-assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity consensus-critical icebox Issues that are not being worked on
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

4 participants