Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add new fields to the sbtc clarity map #800

Open
2 tasks
djordon opened this issue Nov 8, 2024 · 0 comments · May be fixed by #848
Open
2 tasks

[Feature]: Add new fields to the sbtc clarity map #800

djordon opened this issue Nov 8, 2024 · 0 comments · May be fixed by #848
Assignees
Labels
clarity The clarity smart contracts.

Comments

@djordon
Copy link
Contributor

djordon commented Nov 8, 2024

Feature - Add new fields to sbtc clarity maps

1. Description

We added new input parameters to some of the contract calls as part of #583, #547, and #488. We should update the withdrawal-requests and completed-deposits maps in the registry with the sweep-txid, sweep-burn-hash, and sweep-burn-height values when completing the deposit and accepting the withdrawal request.

1.1 Context & Purpose

Adding this data is mainly for "completeness" of the protocol, and to give some flexibility of the signers (or any other observers) getting up-to-date data, even if they miss a webhook from stacks-core.

2. Technical Details:

2.1 Acceptance Criteria:

  • Store the sweep-txid, sweep-burn-hash, and sweep-burn-height data in the completed-deposits map.
  • Store the sweep-txid, sweep-burn-hash, and sweep-burn-height data in the withdrawal-requests map.

3. Related Issues and Pull Requests (optional):

relates to

@djordon djordon added this to the sBTC: Deposit ready milestone Nov 8, 2024
@djordon djordon added the clarity The clarity smart contracts. label Nov 8, 2024
@djordon djordon added this to sBTC Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Nov 8, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Nov 12, 2024
@setzeus setzeus linked a pull request Nov 15, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity The clarity smart contracts.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants