Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Separate blocklist client responses from can-sign status #839

Closed
1 task
djordon opened this issue Nov 14, 2024 · 0 comments · Fixed by #838
Closed
1 task

[Feature]: Separate blocklist client responses from can-sign status #839

djordon opened this issue Nov 14, 2024 · 0 comments · Fixed by #838
Assignees
Labels
deposit The deposit sBTC operation. sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Nov 14, 2024

Feature - Separate blocklist client responses from can-sign status

1. Description

Currently, we don't use the blocklist client if the signer wasn't part of the signing set that created the deposit's aggregate key. By separating these, a signer could sign other digests within a transaction.

1.1 Context & Purpose

When deciding whether to sign transaction digests, signers need to know if they are part of the signing set that created the aggregate key and whether they wish to block the deposit. If all deposits are acceptable but a signer isn't part of the signing set locking some deposits, they should sign for the deposits that they can. The current code doesn't make that distinction possible.

2. Technical Details:

2.1 Acceptance Criteria:

  • Always run the blocklist client for each deposit, not just ones that the signer can sign for.

3. Related Issues and Pull Requests (optional):

This came up as part of #798.

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. deposit The deposit sBTC operation. labels Nov 14, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 14, 2024
@djordon djordon self-assigned this Nov 14, 2024
@djordon djordon added this to sBTC Nov 14, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Nov 14, 2024
@djordon djordon moved this from Needs Triage to In Review in sBTC Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deposit The deposit sBTC operation. sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant