Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signers create bitcoin sighashes #849

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Nov 15, 2024

Description

Closes #798.

I want to change the name of at least one of the structs. If you have any suggestions I'm all ears.

Changes

  1. Allow for us to get an UnsignedTransaction with witness data.
  2. A small refactor where I changed the name of the validation types.
  3. Add functions that take a sequence of inputs and outputs identifiers, does validation on the associated requests, and creates the associated sighashes.
  4. Added stubs for logic that still needs some doing.

This PR does not implement any "cascading" of an invalid transaction to child transactions in the chain. That's still todo, but probably not in this PR.

Testing Information

This still needs some tests, hence the draft status, but it is ready for review.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. deposit The deposit sBTC operation. labels Nov 15, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 15, 2024
@djordon djordon self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deposit The deposit sBTC operation. sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Feature]: Signers create bitcoin sighashes for bitcoin sign requests
1 participant