Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Signers check sighash before participating in signing rounds #793

Open
1 task
djordon opened this issue Nov 8, 2024 · 0 comments
Open
1 task
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Nov 8, 2024

Feature - Signers check sighash before participating in signing rounds

1. Description

This is ticket corresponds to point (7) in 3.1 in #782. Signers need to look up the sighash/digest from the database and decide whether to participate in the signing round based off of the stored decision.

1.1 Context & Purpose

One of the last steps of the bitcoin validation flow is refusing to sign sighashes that a signer cannot or will not sign for. This decision is stored before hand, we just need to use this decision when the coordinator asks for a signature.

2. Technical Details:

When a signer receives a sign requests message from the coordinator, the signer looks up their decision from the database and participates if the decision was to participate.

2.1 Acceptance Criteria:

  • Signers do not participate in signing rounds where they have decided not to sign a particular sighash.

3. Related Issues and Pull Requests (optional):

Relates to

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Nov 8, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 8, 2024
@djordon djordon added this to sBTC Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Nov 8, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Nov 8, 2024
@Jiloc Jiloc self-assigned this Nov 13, 2024
@Jiloc Jiloc moved this from Todo to In Progress in sBTC Nov 13, 2024
@Jiloc Jiloc removed their assignment Nov 13, 2024
@djordon djordon moved this from In Progress to Todo in sBTC Nov 13, 2024
@djordon djordon moved this from Todo to In Progress in sBTC Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Todo
Development

No branches or pull requests

2 participants