feat: Add production like docker compose for docs #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshtonStephens
added
the
documentation
2 tasks
cylewitruk
reviewed
Nov 12, 2024
| COPY --from=dobtc/bitcoin:25.1 /opt/bitcoin-*/bin /usr/local/bin | ||
|
|
||
| RUN apt-get update && apt-get install -y curl jq zstd | ||
| RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* |
There was a problem hiding this comment.
Just a little note that this doesn't reduce the final image size as it's still included in a previous layer, unless the image is built with --squash.
| # !! Block Notifier Configuration | ||
| # !! ============================================================================== | ||
| # Electrum server connection confirmation. | ||
| [block_notifier] |
There was a problem hiding this comment.
You know, I thought I had removed this a while back -- anyone know how/why it's popped back up?
| - postgres | ||
| environment: | ||
| RUST_LOG: info | ||
| SIGNER_SIGNER__P2P__LISTEN_ON: tcp://0.0.0.0:4122 |
There was a problem hiding this comment.
I don't think we need the SIGNER_ env-vars here. This was a solution in devenv to use the config file as a base, but these needed to be different for each signer instance. For this example I think everything can just be pulled from the config.
djordon
reviewed
Nov 15, 2024
| services: | ||
|
|
||
| postgres: | ||
| image: postgres:15-alpine |
There was a problem hiding this comment.
We should update this to 16.3, which is what we test against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #785
This PR creates a docker compose and configuration files meant to be used solely in documentation. The primary goal is
to give those who will be running signers the right idea of what will be required. This docker compose calls upon docker
images that aren't published yet.
I fully expect us to need to make decent changes to these, but the communication aspect won't be greatly changed by
the changes we'll need to make.
I've opted to leave in some of the
TODO(123)comments in the signer configuration because I think leaving them inmakes it clearer what work needs to be done and what they can expect will have changes before they deploy.
Changes
Adds three files:
Testing Information
Not tested.
Checklist: