You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feature - More efficient validation of complete-deposit contract calls
1. Description
1.1 Context & Purpose
One of our slowest queries is the one behind get_swept_deposit_requests. The coordinator uses this query to figure out which deposit requests need a corresponding mint, and the other signers use this query during validation of the complete-deposit contract call. It would be more performant for the signers to use a more specialized query along with a request to their stacks node when validating the contract call. This approach has the benefit of allowing signers to miss the completed-deposit event from the stacks node for validation of contract call transactions.
2. Technical Details:
We'll need to add another method to the StacksInteract trait that fetches the "status" of a deposit request from the sbtc-registry by making a call to the get-deposit-status read-only function. Then we can use this during validation of the stacks transaction. We would also need to use the get_deposit_request_report query during validation, which should be much faster since it does not touch the stacks blockchain data.
2.1 Acceptance Criteria:
We do not use slow queries during validation of complete-deposit contract calls.
3. Related Issues and Pull Requests (optional):
This is tied to some other performance improvement tickets, like #1295.
The text was updated successfully, but these errors were encountered:
Feature - More efficient validation of complete-deposit contract calls
1. Description
1.1 Context & Purpose
One of our slowest queries is the one behind
get_swept_deposit_requests
. The coordinator uses this query to figure out which deposit requests need a corresponding mint, and the other signers use this query during validation of thecomplete-deposit
contract call. It would be more performant for the signers to use a more specialized query along with a request to their stacks node when validating the contract call. This approach has the benefit of allowing signers to miss thecompleted-deposit
event from the stacks node for validation of contract call transactions.2. Technical Details:
We'll need to add another method to the
StacksInteract
trait that fetches the "status" of a deposit request from the sbtc-registry by making a call to theget-deposit-status
read-only function. Then we can use this during validation of the stacks transaction. We would also need to use theget_deposit_request_report
query during validation, which should be much faster since it does not touch the stacks blockchain data.2.1 Acceptance Criteria:
3. Related Issues and Pull Requests (optional):
This is tied to some other performance improvement tickets, like #1295.
The text was updated successfully, but these errors were encountered: