Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Log startup errors #1288

Closed
matteojug opened this issue Jan 30, 2025 · 0 comments · Fixed by #1311
Closed

[Chore]: Log startup errors #1288

matteojug opened this issue Jan 30, 2025 · 0 comments · Fixed by #1311
Assignees
Labels

Comments

@matteojug
Copy link
Collaborator

Chore - Log startup errors

1. Description

The errors returned from main are not logged to the usual logs, eg if we fail to parse the config (missing some required fields):

let settings = Settings::new(args.config)?;

We should log whatever error we get from main before exiting.

2. Why It's Necessary

Without it, we just see no more logs, which is not really nice.

@matteojug matteojug added this to the sBTC: Deposits milestone Jan 30, 2025
@matteojug matteojug added this to sBTC Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 30, 2025
@matteojug matteojug moved this from Needs Triage to Todo in sBTC Jan 30, 2025
@MCJOHN974 MCJOHN974 self-assigned this Jan 30, 2025
@djordon djordon moved this from Todo to In Review in sBTC Feb 6, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants