Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Setup ledger reclaim testing #1278

Closed
1 task
djordon opened this issue Jan 28, 2025 · 1 comment
Closed
1 task

[Feature]: Setup ledger reclaim testing #1278

djordon opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
P0 Critical Priority

Comments

@djordon
Copy link
Collaborator

djordon commented Jan 28, 2025

Feature - Setup ledger reclaim testing

1. Description

1.1 Context & Purpose

We need to make sure that users who make a deposit request from a Ledger device can reclaim their funds if the request is "rejected". Ledger is quite picky about things, so we need to make sure that our deposit protocol is always compatible ledger. The task is to make sure that any changes that break this compatibility is detected, either manually or in CI.

2. Technical Details:

Ledger provides an emulator in https://github.com/LedgerHQ/speculos. They also provide a few bitcoin client libraries for developers to test interacting with ledger, with the Rust library living here: https://github.com/LedgerHQ/app-bitcoin-new/tree/develop/bitcoin_client_rs (and published on crates.io). Add an example, or an integration test if possible, that tests that a user can reclaim their deposited funds. This example or test should live in the sbtc crate in this repo. In either example, we should include instructions for how to set up the emulator before running the example or test.

2.1 Acceptance Criteria:

  • We have an example or integration test where we can check that a deposit can be reclaimed for Ledger users.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the P0 Critical Priority label Jan 28, 2025
@djordon djordon added this to the sBTC: Deposits milestone Jan 28, 2025
@djordon djordon added this to sBTC Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 28, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Jan 28, 2025
@MCJOHN974
Copy link
Collaborator

Replaced with #1293

@github-project-automation github-project-automation bot moved this from Todo to Done in sBTC Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical Priority
Projects
Status: Done
Development

No branches or pull requests

2 participants