Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: reconsider signer behaviour related to Emily sBTC limits #1244

Open
matteojug opened this issue Jan 20, 2025 · 0 comments
Open

[Chore]: reconsider signer behaviour related to Emily sBTC limits #1244

matteojug opened this issue Jan 20, 2025 · 0 comments
Labels

Comments

@matteojug
Copy link
Collaborator

Chore - reconsider signer behaviour related to Emily sBTC limits

1. Description

The block observer fetches the limits from Emily, after processing the block but before fetching new requests from Emily. If we fail to get the limits, we skip loading new requests from Emily.

if let Err(error) = self.update_sbtc_limits().await {
tracing::warn!(%error, "could not update sBTC limits");
continue;
}

In case of failures in getting the limits (Emily unreachable, breaking change in the limit format, ...), while we would not process new requests, already known requests in the database would still be processed using the last known limits.

This task is to re-evaluate if we want to keep this behaviour, or if we prefer to bail/default to conservative limits even if we have some previous known limits.

@matteojug matteojug added this to sBTC Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant