Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way for running the tests with different epoch/clarity versions #342

Open
Acaccia opened this issue Feb 19, 2024 · 4 comments
Open
Assignees
Labels

Comments

@Acaccia
Copy link
Collaborator

Acaccia commented Feb 19, 2024

Issue #340 showed a bug that happened at epoch20 but not at the latest one.

It seems that the typechecker phase runs two different versions of the typechecker depending if epoch >= 2.1, as we can see in the run_analysis function.

We should add new steps to our current tests to make sure that it works with both versions of the typechecker.

We should also investigate if the clarity version can provoke bugs too.

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Mar 5, 2024
@smcclellan smcclellan added this to the WASM Phase 1 milestone Mar 12, 2024
@smcclellan smcclellan moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Mar 18, 2024
@smcclellan smcclellan modified the milestones: WASM Phase 1, WASM Phase 3 Mar 26, 2024
@csgui csgui self-assigned this Nov 5, 2024
@csgui csgui moved this from Status: 📋 Backlog to Status: 💻 In Progress in Stacks Core Eng Dec 4, 2024
@smcclellan
Copy link

Closed by #498.

@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Dec 17, 2024
@Acaccia
Copy link
Collaborator Author

Acaccia commented Dec 17, 2024

This PR doesn't add tests for different epochs with same Clarity version.

@Acaccia Acaccia reopened this Dec 17, 2024
@github-project-automation github-project-automation bot moved this from Status: ✅ Done to Status: 🆕 New in Stacks Core Eng Dec 17, 2024
@csgui
Copy link
Collaborator

csgui commented Dec 17, 2024

@Acaccia I think it’s not necessary to test earlier epochs, since clarity-wasm will not be active until later epochs (currently set to 3.0). It is important to test the different Clarity versions, that is what we are already doing. Don’t you think?

@Acaccia
Copy link
Collaborator Author

Acaccia commented Dec 18, 2024

From what I understood, the compiler is supposed to work for already deployed contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants