Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify generator and builder in traverse/visit abstractions. #239

Open
krl opened this issue Jan 8, 2024 · 0 comments
Open

Unify generator and builder in traverse/visit abstractions. #239

krl opened this issue Jan 8, 2024 · 0 comments
Labels
code quality Improving the quality of the code, and dev experience
Milestone
WASM MVP2 : Cost ...

Comments

@krl
Copy link
Collaborator

krl commented Jan 8, 2024

The arguments generator and builder are always passed together when compiling.

It would make sense to unify these into one argument, and additionally include some quality of life methods for our specific use case.

Examples include:

  • builder.if_else( .. ) that can handle Result types
  • Cleanup of returning from clarity calls, automatically handling early returns.
@krl krl added the code quality Improving the quality of the code, and dev experience label Jan 8, 2024
@krl krl mentioned this issue Jan 22, 2024
Merged
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Feb 2, 2024
@smcclellan smcclellan added this to the WASM Phase 3 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improving the quality of the code, and dev experience
Projects
Stacks Core Eng
Status: Status: 🆕 New
Milestone
WASM MVP2 : Cost Tracking, Misc
Development

No branches or pull requests
2 participants
@krl @smcclellan