Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review panics and todos in clar2wasm #110

Open
obycode opened this issue Sep 29, 2023 · 0 comments
Open

Review panics and todos in clar2wasm #110

obycode opened this issue Sep 29, 2023 · 0 comments

Comments

@obycode
Copy link
Collaborator

obycode commented Sep 29, 2023

There are some panics (usually from an expect) in the code. These are currently only for things that should never happen, but since it is easy to just return an error instead of panicking, let's always do that, and never panic. The only places where panics should remain would be for calls with literal arguments that can be statically verified that the panic will never occur, for example ClarityName::try_from("reporter").expect("BUG: valid string representation").

We also need to review any places where todo items were left in the code and ensure that an issue is opened for each of these items.

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Oct 2, 2023
@obycode obycode moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Oct 2, 2023
@obycode obycode changed the title Review panics in clar2wasm Review panics and todos in clar2wasm Jan 4, 2024
@ameeratgithub ameeratgithub self-assigned this Jan 5, 2024
@smcclellan smcclellan added this to the WASM Phase 3 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 📋 Backlog
Development

No branches or pull requests

3 participants