Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muncher rules review #36

Open
9 tasks
rimutaka opened this issue Sep 5, 2021 · 1 comment
Open
9 tasks

Muncher rules review #36

rimutaka opened this issue Sep 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rimutaka
Copy link
Member

rimutaka commented Sep 5, 2021

Adding more munchers prompts a review of what is already in place. Relates to #8, #7.

  • rename "brackets only" to "white space"
  • rename "inline comments" to "other comments" in the front end
  • recheck all regex for \s use and replace it with [:blank:] to exclude line breaks
  • add a rule for sibling file names check - a .h file can belong to C or C++
  • add .cc, .C and other variations to C++
  • add .cu CUDA files somewhere

Older munchers

These munchers need a full review and testing.

  • csharp
  • js
  • powershell
  • python
  • rust
  • scss
  • sql
  • ts

Ignore list

A rule with no muncher is essentially an instruction to ignore.

  • check if the current will do that or fail
  • check if we need a catch-all rule with an ignore list of directories, e.g. node-modules or bin that is checked before the file type is checked
  • add ignore list for images, binaries
    Some files may need to be added to anti-patterns such as including /bin/ in your repo. Not sure it's a good idea.
@rimutaka rimutaka added the enhancement New feature or request label Sep 5, 2021
rimutaka added a commit that referenced this issue Sep 5, 2021
rimutaka added a commit that referenced this issue Sep 5, 2021
@rimutaka
Copy link
Member Author

rimutaka commented Sep 6, 2021

Testing a language search in GH:

curl \
  -H "Accept: application/vnd.github.v3+json" \
https://api.github.com/search/repositories?q=language:Go+sort:updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant