remove obsolete check // add missing unit test

Author: GokceGK

internal/cmd/beta/logs/instance/list/list.go

@@ -130,17 +130,10 @@ func outputResult(p *print.Printer, outputFormat, projectLabel string, instances
 		table := tables.NewTable()
 		table.SetHeader("NAME", "ID", "STATUS")
 		for _, instance := range instances {
-			instance := instances[i]
-
-			instanceStatus := ""
-			if instance.Status != nil {
-				instanceStatus = utils.PtrString(instance.Status)
-			}
-
 			table.AddRow(
 				utils.PtrString(instance.DisplayName),
 				utils.PtrString(instance.Id),
-				instanceStatus,
+				utils.PtrString(instance.Status),
 			)
 		}
 		err := table.Display(p)

internal/cmd/beta/logs/instance/update/update_test.go

@@ -294,3 +294,47 @@ func TestBuildRequest(t *testing.T) {
 		})
 	}
 }
+
+func TestOutputResult(t *testing.T) {
+	tests := []struct {
+		description string
+		model       *inputModel
+		instance    *logs.LogsInstance
+		wantErr     bool
+	}{
+		{
+			description: "nil response",
+			instance:    nil,
+			wantErr:     true,
+		},
+		{
+			description: "default output",
+			instance:    &logs.LogsInstance{},
+			model:       &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}},
+			wantErr:     false,
+		},
+		{
+			description: "json output",
+			instance:    &logs.LogsInstance{},
+			model:       &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{OutputFormat: print.JSONOutputFormat}},
+			wantErr:     false,
+		},
+		{
+			description: "yaml output",
+			instance:    &logs.LogsInstance{},
+			model:       &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{OutputFormat: print.YAMLOutputFormat}},
+			wantErr:     false,
+		},
+	}
+
+	p := print.NewPrinter()
+	p.Cmd = NewCmd(&types.CmdParams{Printer: p})
+	for _, tt := range tests {
+		t.Run(tt.description, func(t *testing.T) {
+			err := outputResult(p, tt.model, "label", tt.instance)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}