Flip machine readiness through MachineScope.SetNotReady instead of assigning Status.Ready directly

Author: Herbaert

controller/stackitmachine_infrastructure.go

@@ -73,9 +73,7 @@ func (r *StackitMachineReconciler) reconcileNormal(ctx context.Context, s *scope
 
 	server, created, err := r.ensureServer(ctx, cloudClient, s, bootstrapData)
 	if err != nil {
-		// Keep the legacy boolean in step with the conditions: a machine whose
-		// server could not be ensured is not ready, even if it was before.
-		sm.Status.Ready = false
+		s.SetNotReady("InstanceError", err.Error(), infrav1.MachineInstanceReadyCondition, infrav1.MachineReadyCondition)
 		return util.CloudFailureResult(
 			&sm.Status.Conditions,
 			sm.Generation,
@@ -103,7 +101,7 @@ func (r *StackitMachineReconciler) reconcileNormal(ctx context.Context, s *scope
 	}
 
 	if err := r.reconcileBastionNodeSSHAccess(ctx, cloudClient, s, server); err != nil {
-		sm.Status.Ready = false
+		s.SetNotReady("BastionSSHAccessError", err.Error(), infrav1.MachineReadyCondition)
 		return util.CloudFailureResult(
 			&sm.Status.Conditions,
 			sm.Generation,
@@ -116,7 +114,7 @@ func (r *StackitMachineReconciler) reconcileNormal(ctx context.Context, s *scope
 	}
 
 	if err := r.reconcileAPIServerLoadBalancerTarget(ctx, cloudClient, s, server); err != nil {
-		sm.Status.Ready = false
+		s.SetNotReady("LoadBalancerTargetError", err.Error(), infrav1.MachineReadyCondition)
 		return util.CloudFailureResult(
 			&sm.Status.Conditions,
 			sm.Generation,