Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove home: from refs #637

Closed
91 tasks done
Tracked by #557
NickLarsenNZ opened this issue Aug 1, 2024 · 1 comment
Closed
91 tasks done
Tracked by #557

fix: remove home: from refs #637

NickLarsenNZ opened this issue Aug 1, 2024 · 1 comment

Comments

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Aug 1, 2024

From @fhennig:
The problem is in the include directives in the operators, on the old branches. The docs state:

If the version coordinate isn’t specified, Antora uses the latest version of the target page’s component to complete the resource ID at runtime. This behavior only applies when the target page and current page belong to different docs components.

This means that if a component is specified in an include directive (i.e. "home") but without a version, the latest version is used. We do not want that we want to include from the same version. The fix is to simply remove the component directive. I've made a fix for Airflow 24.3, here is the commit: stackabletech/airflow-operator@669691c

unfortunately this means that you will need to push this fix into all release branches of all operators ... so a lot of PRs

Example fix:

- include::home:concepts:stackable_resource_requests.adoc[]
+ include::concepts:stackable_resource_requests.adoc[]
  1. Checkout the release-xx.xx branch (make sure it is up to date)
  2. Create a new branch off it, fix/release-xx.xx-remove-home-xref
    Sample commit message: docs: remove home module from refs (stackabletech/documentation#637)
  3. Raise a PR back into the release-xx.xx branch

Note

The documentation repo uses the release/xx.xx style.

Update the below tasklists with the subsequent PR

Non-Operators Repos

Fixes for documentation releases

Operators

Fixes for commons-operator releases

Fixes for listener-operator releases

Fixes for secret-operator releases

@NickLarsenNZ NickLarsenNZ transferred this issue from stackabletech/issues Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix: remove home:: from xrefs fix: remove home: from refs Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
lfrancke added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/nifi-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
sbernauer added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
maltesander pushed a commit to stackabletech/druid-operator that referenced this issue Aug 1, 2024
maltesander pushed a commit to stackabletech/druid-operator that referenced this issue Aug 1, 2024
xeniape added a commit to stackabletech/airflow-operator that referenced this issue Aug 1, 2024
@lfrancke lfrancke pinned this issue Aug 1, 2024
maltesander added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
@lfrancke lfrancke unpinned this issue Aug 1, 2024
maltesander added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
xeniape added a commit to stackabletech/airflow-operator that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/commons-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/trino-operator that referenced this issue Aug 1, 2024
lfrancke pushed a commit to stackabletech/trino-operator that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/airflow-operator that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/airflow-operator that referenced this issue Aug 1, 2024
maltesander added a commit to stackabletech/airflow-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
lfrancke pushed a commit to stackabletech/zookeeper-operator that referenced this issue Aug 1, 2024
NickLarsenNZ added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
docs: add home module for refs that didn't exist in this release (stackabletech/documentation#637)
xeniape added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
docs: add home module for refs that didn't exist in this release (stackabletech/documentation#637)
xeniape added a commit to stackabletech/demos that referenced this issue Aug 1, 2024
docs: add home module for refs that didn't exist in this release (stackabletech/documentation#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant