Merge branch 'stackable' of https://github.com/stackabletech/SecObserve into stackable

Author: dervoeti

backend/application/core/api/serializers_observation.py

@@ -128,7 +128,7 @@ def get_origin_cloud_resource_url(self, observation: Observation) -> Optional[st
     def get_issue_tracker_issue_url(self, observation: Observation) -> Optional[str]:
         issue_url = None
 
-        if observation.issue_tracker_issue_id:
+        if observation.issue_tracker_issue_id and observation.product.issue_tracker_type:
             issue_tracker = issue_tracker_factory(observation.product, with_communication=False)
             issue_url = issue_tracker.get_frontend_issue_url(observation.product, observation.issue_tracker_issue_id)
 

backend/application/core/services/observation_log.py

@@ -51,7 +51,7 @@ def create_observation_log(  # pylint: disable=too-many-arguments
     if assessment_status in (
         Assessment_Status.ASSESSMENT_STATUS_APPROVED,
         Assessment_Status.ASSESSMENT_STATUS_AUTO_APPROVED,
-        Assessment_Status.ASSESSMENT_STATUS_REMOVED,
+        Assessment_Status.ASSESSMENT_STATUS_REMOVED
     ):
         send_observation_notification(observation)
         send_observation_title_notification(observation)

backend/application/notifications/services/send_notifications_observation_title.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from application.access_control.services.current_user import get_current_user
 from application.commons.models import Settings
 from application.commons.services.functions import get_base_url_frontend