RetroBooster & BoostedStrategyBase #130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
a17
commented
May 12, 2024
•
a17
commented
- RetroBooster
- hold veNFT
- increase lock period
- cast vote
- claim bribes
- hold pool strategy positions (NFT and ALM LP)
- store pool strategy earned Merkl rewards
- LiquidToken
- Platform
- boosters management
- Gauge
- BoostedStrategyBase
- skeleton
- logic
- tests
- ...
a17
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 94.73% 93.27% -1.47%
==========================================
Files 58 62 +4
Lines 4273 4340 +67
Branches 465 473 +8
==========================================
Hits 4048 4048
- Misses 77 144 +67
Partials 148 148 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+38
to
+41
| function __BoostedStrategyBase_init(address booster_) internal onlyInitializing { | ||
| BoostedStrategyBaseStorage storage $ = _getBoostedStrategyBaseStorage(); | ||
| $.booster = booster_; | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
Comment on lines
+10
to
+62
| abstract contract BoostedStrategyBase is StrategyBase, IBoostedStrategy { | ||
| /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/ | ||
| /* CONSTANTS */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| /// @dev Version of BoostedStrategyBase implementation | ||
| string public constant VERSION_BOOSTED_STRATEGY_BASE = "1.0.0"; | ||
|
|
||
| // todo set | ||
| // keccak256(abi.encode(uint256(keccak256("erc7201:stability.BoostedStrategyBase")) - 1)) & ~bytes32(uint256(0xff)); | ||
| bytes32 private constant BOOSTEDSTRATEGYBASE_STORAGE_LOCATION = | ||
| 0xe61f0a7b2953b9e28e48cc07562ad7979478dcaee972e68dcf3b10da2cba6000; | ||
|
|
||
| /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/ | ||
| /* DATA TYPES */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| /// @custom:storage-location erc7201:stability.BoostedStrategyBase | ||
| struct BoostedStrategyBaseStorage { | ||
| /// @inheritdoc IBoostedStrategy | ||
| address booster; | ||
| } | ||
|
|
||
| /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/ | ||
| /* INITIALIZATION */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| //slither-disable-next-line naming-convention | ||
| function __BoostedStrategyBase_init(address booster_) internal onlyInitializing { | ||
| BoostedStrategyBaseStorage storage $ = _getBoostedStrategyBaseStorage(); | ||
| $.booster = booster_; | ||
| } | ||
|
|
||
| /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/ | ||
| /* VIEW FUNCTIONS */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| /// @inheritdoc IBoostedStrategy | ||
| function booster() external view returns (address) { | ||
| return _getBoostedStrategyBaseStorage().booster; | ||
| } | ||
|
|
||
| /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/ | ||
| /* INTERNAL LOGIC */ | ||
| /*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/ | ||
|
|
||
| function _getBoostedStrategyBaseStorage() internal pure returns (BoostedStrategyBaseStorage storage $) { | ||
| //slither-disable-next-line assembly | ||
| assembly { | ||
| $.slot := BOOSTEDSTRATEGYBASE_STORAGE_LOCATION | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Unimplemented functions Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.