[FIX] Folder ignore sorts all folder starting with string #972

4Source · 2024-05-24T23:02:54Z

Fixes #969

Implementation of better comparison
Implementation of Unit Test

4Source · 2024-05-24T23:15:07Z

Not sure why the Test Failed for me tried it multiple times no issues with this. Maybe because Test is running on Ubuntu and i am on windows I will check I can Test this on a Virtual machine.

4Source · 2024-05-25T14:35:32Z

Finally Test succeed

ronzulu

LGTM @4Source

Not that it matters too much, but I think we use different terminology in terms of what is "sub". I guess I think of "sub" to encompass less than the original thing, e.g. "subsection".

If I've understood correctly, then I think you have the opposite meaning. That "root" is a subpath of "root/sub/sub2", but encompasses more.

As an idea, what do you think of "isEqualOrAncestor" instead?

Great that you've included comprehensive test cases.

4Source · 2024-07-10T08:23:47Z

Actually I think we have the same understanding of sub.

Not that it matters too much, but I think we use different terminology in terms of what is "sub". I guess I think of "sub" to encompass less than the original thing, e.g. "subsection".

Where do you mean is this the case?

If I've understood correctly, then I think you have the opposite meaning. That "root" is a subpath of "root/sub/sub2", but encompasses more.

I am not a native speaker so If you say this fits more than I can change it

As an idea, what do you think of "isEqualOrAncestor" instead?

ronzulu · 2024-07-11T02:25:59Z

src/util/utils.ts

+ * @tutorial
+ * rootPath = "root/sub/sub2"
+ * if toCheck = "notRoot/..." -> false
+ * if toCheck = "root" -> true


I think I understand the confusion now. Yes we do have the same understanding of the word "sub", this might just be a documentation mistake?

if toCheck = "root" -> true
if toCheck = "root/sub" -> true

Should those be false? I think one of the test cases checks that it is false
expect(isEqualOrSubPath(root, rootPath)).toBe(false);

BTW your English is great!

Yes I think your right the documentation seems to be wrong. And now I understand what you mean with root path is not the correct naming. With rootPath I meant the path and all of its sub paths but It is not actually the root path.

But the test should be correct if the path to check is above the rootPath it is not a part of the sub folders.

st3v3nmw#972 Squashed commit 5b29ae1

* Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement

commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) commit ca4c261 Author: 4Source <[email protected]> Date: Sat May 25 10:13:50 2024 +0200 Improved issue templates (st3v3nmw#963) * Replace bug_report with form instead of template * Replace feature_request with form instead of template * Fix linting commit 053da6a Author: 4Source <[email protected]> Date: Fri May 24 19:59:06 2024 +0200 Update German localization (st3v3nmw#961) * Update German localization * Fix linting

commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982)

commit efebbd4 Author: ronzulu <[email protected]> Date: Wed Aug 7 15:21:28 2024 +1000 Added section: Displaying the Note Review Queue commit 7b0ae5b Author: ronzulu <[email protected]> Date: Thu Aug 1 12:11:38 2024 +1000 Minor commit a6046c1 Author: ronzulu <[email protected]> Date: Tue Jul 30 22:45:07 2024 +1000 Don't format/lint docs - it can mess up formatting of markdown commit eaba4d5 Author: ronzulu <[email protected]> Date: Tue Jul 30 22:24:39 2024 +1000 Ready for review commit 182c8b7 Author: ronzulu <[email protected]> Date: Tue Jul 30 12:16:39 2024 +1000 Minor renaming commit a44a623 Author: ronzulu <[email protected]> Date: Tue Jul 30 12:06:32 2024 +1000 Restructure continued commit d8da4be Author: ronzulu <[email protected]> Date: Tue Jul 30 11:50:12 2024 +1000 Folder restructure - moved contents of docs into new folder docs/docs etc (no change in content) commit 3a7457b Author: ronzulu <[email protected]> Date: Tue Jul 30 11:38:03 2024 +1000 Progress commit 274a970 Author: ronzulu <[email protected]> Date: Mon Jul 29 19:05:41 2024 +1000 Progress commit f6071ae Author: ronzulu <[email protected]> Date: Sun Jul 28 22:55:37 2024 +1000 Progress commit 66ec4c8 Author: ronzulu <[email protected]> Date: Sat Jul 27 15:37:16 2024 +1000 Progress commit 7871d34 Author: ronzulu <[email protected]> Date: Sat Jul 27 11:27:50 2024 +1000 Added a small vault used to generate screenshots for the user guide commit 318a571 Author: ronzulu <[email protected]> Date: Fri Jul 26 15:35:03 2024 +1000 Progress commit f7babfd Author: ronzulu <[email protected]> Date: Fri Jul 26 12:55:13 2024 +1000 Progress commit 337f175 Author: ronzulu <[email protected]> Date: Thu Jul 25 22:53:10 2024 +1000 Progress commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982)

… info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <[email protected]>

* Full coverage for UnitTest utils * Change test config * Added Unit Test for stats * Added Unit Test for NumberCountDict * Add function parseDateToTicks, formatDate * Fix includes and doc * Added Testcases * Remove unused function * Try fix ticksFromDate * Fix lint * [FIX] isEqualOrSubPath function (#1048) * Improve isEqualOrSubPath Description + remove use of normalize * update changelog * fix linting * update changelog * Revert "update changelog" This reverts commit d7ba801. * Update Changelog * feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms (#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post #495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch #878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch #878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <[email protected]> * chore: update dependencies, linting, & tests * update eslint * lower coverage threshold * minor fixes --------- Co-authored-by: 4Source <[email protected]> Co-authored-by: Ronny Zulaikha <[email protected]>

* UPDATE: Extended the amount of information in the card title * UPDATE: Improved card title in random mode * UPDATE: Documented changes & formatted with prettier * Squashed commit of the following: commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (#947) Ignore notes due in the future. Fixes #548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix #1000 sidebar indent (#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (#982) commit ca4c261 Author: 4Source <[email protected]> Date: Sat May 25 10:13:50 2024 +0200 Improved issue templates (#963) * Replace bug_report with form instead of template * Replace feature_request with form instead of template * Fix linting commit 053da6a Author: 4Source <[email protected]> Date: Fri May 24 19:59:06 2024 +0200 Update German localization (#961) * Update German localization * Fix linting * UPDATE: Quick clean up of unused code * UPDATE: Added changelog message again * UPDATE: Executed format script --------- Co-authored-by: Kyle Klus <[email protected]>

* Full coverage for UnitTest utils * Change test config * Added Unit Test for stats * Added Unit Test for NumberCountDict * Add function parseDateToTicks, formatDate * Fix includes and doc * Added Testcases * Remove unused function * Try fix ticksFromDate * Fix lint * [FIX] isEqualOrSubPath function (st3v3nmw#1048) * Improve isEqualOrSubPath Description + remove use of normalize * update changelog * fix linting * update changelog * Revert "update changelog" This reverts commit d7ba801. * Update Changelog * feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms (st3v3nmw#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post st3v3nmw#495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch st3v3nmw#878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch st3v3nmw#878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <[email protected]> * chore: update dependencies, linting, & tests * update eslint * lower coverage threshold * minor fixes --------- Co-authored-by: 4Source <[email protected]> Co-authored-by: Ronny Zulaikha <[email protected]>

4Source added 2 commits May 25, 2024 01:00

Implement isEqualOrSubPath

a3bf17e

Implement UnitTest for isEqualOrSubPath

545222b

4Source added 2 commits May 25, 2024 15:48

Replace separators with system seperator

7511a19

Improved seperator replacement

5b29ae1

ronzulu approved these changes Jul 10, 2024

View reviewed changes

ronzulu reviewed Jul 11, 2024

View reviewed changes

ronzulu added a commit to ronzulu/obsidian-spaced-repetition that referenced this pull request Jul 16, 2024

[FIX] Folder ignore sorts all folder starting with string

438365b

st3v3nmw#972 Squashed commit 5b29ae1

ronzulu added the beta Included in beta release, https://github.com/st3v3nmw/obsidian-spaced-repetition/discussions/1011 label Jul 16, 2024

st3v3nmw merged commit 1dfd52e into st3v3nmw:master Jul 20, 2024
1 check passed

4Source deleted the bug_969 branch July 20, 2024 08:15

4Source restored the bug_969 branch July 20, 2024 08:16

ronzulu mentioned this pull request Aug 7, 2024

[Bug]: After update 1.12.5 does not work in the mobile version of obsidian (android) #1033

Closed

4Source mentioned this pull request Aug 12, 2024

[FIX] isEqualOrSubPath function #1048

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] Folder ignore sorts all folder starting with string #972

[FIX] Folder ignore sorts all folder starting with string #972

4Source commented May 24, 2024

4Source commented May 24, 2024

4Source commented May 25, 2024

ronzulu left a comment

4Source commented Jul 10, 2024

ronzulu Jul 11, 2024

ronzulu Jul 11, 2024

4Source Jul 11, 2024

[FIX] Folder ignore sorts all folder starting with string #972

[FIX] Folder ignore sorts all folder starting with string #972

Conversation

4Source commented May 24, 2024

4Source commented May 24, 2024

4Source commented May 25, 2024

ronzulu left a comment

Choose a reason for hiding this comment

4Source commented Jul 10, 2024

ronzulu Jul 11, 2024

Choose a reason for hiding this comment

ronzulu Jul 11, 2024

Choose a reason for hiding this comment

4Source Jul 11, 2024

Choose a reason for hiding this comment