Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: entire committee slot fails due to slashing protection instead of affected validator #1913

Open
olegshmuelov opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@olegshmuelov
Copy link
Contributor

olegshmuelov commented Dec 4, 2024

#1902 introduced a fix preventing attesting at the epoch it was registered or reactivated
and not by slashing protection as it was before causing the whole committee slot to fail.

In rare case below we still can bypass the minParticipationEpoch protection

  1. If a validator (e.g., Validator X) is registered at the very first slot of an epoch.
  2. Immediately after the registration, there is a restart (e.g., due to a node crash or manual restart).
  3. Validator X has a duty at slot n (later in the same epoch) as part of a committee with other validators.
    In this scenario, the restart would potentially result in the failure of all committee slots because the state needed to recognize Validator X’s registration might not persist correctly across the restart. This could lead to missed duties for the entire committee

It might be worth considering additional safeguards to handle state persistence during restarts or improving recovery logic to avoid this failure scenario.

Originally posted by @olegshmuelov in #1898 (comment)

@olegshmuelov olegshmuelov added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant