fix: duty scheduler indices change & reorg bleeps #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0sher
approved these changes
Sep 11, 2024
y0sher
approved these changes
Sep 15, 2024
This was referenced Sep 16, 2024
Open
iurii-ssv
reviewed
Oct 23, 2024
Comment on lines
303
to
305
| func (h *AttesterHandler) shouldFetchNexEpoch(slot phase0.Slot) bool { | ||
| return uint64(slot)%h.network.Beacon.SlotsPerEpoch() > h.network.Beacon.SlotsPerEpoch()/2-2 | ||
| return uint64(slot)%h.network.Beacon.SlotsPerEpoch() >= h.network.Beacon.SlotsPerEpoch()/2-1 | ||
| } |
There was a problem hiding this comment.
Would be nice to have this clarifying comment (for the reason for why we are doing this) here:
// If we have reached the mid-point of the epoch, fetch the duties for the next epoch in the next slot.
// This allows us to set them up at a time when the beacon node should be less busy.
also maybe fix typo shouldFetchNexEpoch -> shouldFetchNextEpoch
Comment on lines
+96
to
+98
| if uint64(slot)%h.network.Beacon.SlotsPerEpoch() > h.network.Beacon.SlotsPerEpoch()/2-1 { | ||
| h.fetchNextEpoch = true | ||
| } |
There was a problem hiding this comment.
Can use if h.shouldFetchNexEpoch(... here ? Although it uses >= (would be nice to clarify which is the correct one).
Comment on lines
+176
to
+180
| // If we have reached the mid-point of the epoch, fetch the duties for the next epoch in the next slot. | ||
| // This allows us to set them up at a time when the beacon node should be less busy. | ||
| if uint64(slot)%slotsPerEpoch == slotsPerEpoch/2-1 { | ||
| h.fetchNextEpoch = true | ||
| } |
There was a problem hiding this comment.
Can use if h.shouldFetchNexEpoch(... here ? I guess applies to other Duties changed in this PR too.
Comment on lines
+182
to
+185
| // last slot of epoch | ||
| if uint64(slot)%slotsPerEpoch == slotsPerEpoch-1 { | ||
| h.duties.Reset(epoch - 1) | ||
| } |
There was a problem hiding this comment.
Would be nice to have helper func similar to shouldFetchNexEpoch for uint64(slot)%slotsPerEpoch == slotsPerEpoch-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1724
close #1714
close #1807