Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate tests.json files to smaller files #482

Open
Tracked by #283
GalRogozinski opened this issue Aug 14, 2024 · 2 comments · May be fixed by #509
Open
Tracked by #283

Seperate tests.json files to smaller files #482

GalRogozinski opened this issue Aug 14, 2024 · 2 comments · May be fixed by #509
Labels
meta refactor

Comments

@GalRogozinski
Copy link
Contributor

Description

We want each test to be represented by his own file.
This is so that we can track changes with more ease.

Requirements

[ ] - large tests.json file should be still generated but taken out of the repo
[ ] - instead commit to the repo the small tests.json files
[ ] - stop compressing the large json file (because git already does compression so it is redundant)
@GalRogozinski GalRogozinski mentioned this issue Aug 14, 2024
Open
9 tasks
@alan-ssvlabs
Copy link

alan-ssvlabs commented Oct 7, 2024 •
edited
Loading

If we create small json files for each tests and agree to take out large tests.json from the repo, why do we still need to generate large tests.json? We can also change TestJson to use small json files.

@GalRogozinski
Copy link
Contributor Author

currently the ssv node uses this large file...
we can make them transition to read lots of small files...
Up until now they didn't have time to breath but maybe we can sync with @moshe-blox

In the meanwhile leave the requirement as is

This was referenced Oct 8, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Commit small test json files for each test instead of the large ones alan-ssvlabs/ssv-spec
2 participants
@GalRogozinski @alan-ssvlabs