Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instead of storing a map of shares here, i think we should store map of shares in CommitteeRunner and only a single share in the other runners #464

Open
GalRogozinski opened this issue Jul 14, 2024 · 1 comment
Open

instead of storing a map of shares here, i think we should store map of shares in CommitteeRunner and only a single share in the other runners #464

GalRogozinski opened this issue Jul 14, 2024 · 1 comment
Labels
refactor

Comments

@GalRogozinski
Copy link
Contributor 

          instead of storing a map of shares here, i think we should store map of shares in CommitteeRunner and only a single share in the other runners

(remove share(s) from BaseRunner)
and then we wont have this weird issue of ranging over 1 share in every runner except CommitteeRunner

Originally posted by @moshe-blox in #421 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GalRogozinski