Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecidedValue in BaseRunner has a misleading name. #458

Open
GalRogozinski opened this issue Jul 7, 2024 · 0 comments
Open

DecidedValue in BaseRunner has a misleading name. #458

GalRogozinski opened this issue Jul 7, 2024 · 0 comments

Comments

@GalRogozinski
Copy link
Contributor 

          `DecidedValue` in BaseRunner has a misleading name.

If a value was decided on but in the post consensus stage it was rejected due to slashing checks, BaseRunner.DecidedValue will be null while Instance.DecidedValue won't be.

So I propose changing the name here to Value or something else...

Originally posted by @GalRogozinski in #457 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GalRogozinski