Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take the OperatorID field out of partialSigMessage #422

Open
GalRogozinski opened this issue Jun 4, 2024 · 1 comment
Open

Take the OperatorID field out of partialSigMessage #422

GalRogozinski opened this issue Jun 4, 2024 · 1 comment
Labels
fork

Comments

@GalRogozinski
Copy link
Contributor

Description

It seems that the OperatorID (Signer) usage is used in PartialSigContainer and PreconsensusJustifications (currently disabled).
For both cases using ValidatorIndex can work and seems to be more correct..
Once this is changed the OperatorID field can be taken out of PartialSigMessage.
@GalRogozinski
Copy link
Contributor Author

Apparently I was a little wrong here.
A <validatorIndex, signingRoot> pair isn't enough because each validator is separated to different parts.

However since SignedSSVMessage has OperatorIDs field we have some duplication.
It is just a bit not nice that a field that is in the outer wrapper that is supposed to be used by MessageValidation will also be used for the MPC part of the protocol...

@GalRogozinski GalRogozinski mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GalRogozinski