You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
There appears to be a redundancy in the validation of consensus data, resulting in the same checks being conducted twice. This redundancy could be unnecessarily extending the time taken for consensus.
Details
The validation check for the input data (byts) is performed twice:
In the BaseRunner.decide method:
// BaseRunner.decide methodiferr:=runner.GetValCheckF()(byts); err!=nil {
returnerrors.Wrap(err, "input data invalid")
}
Given that BaseRunner.decide calls Controller.StartNewInstance, this results in the same validation check being performed twice on the same data.
Suggestion
To optimize the consensus time, I propose removing one of these duplicate checks. My recommendation would be to keep the validation in the Controller.StartNewInstance method, as it seems more contextually appropriate for the responsibility of starting a new QBFT instance.
The text was updated successfully, but these errors were encountered:
Description
There appears to be a redundancy in the validation of consensus data, resulting in the same checks being conducted twice. This redundancy could be unnecessarily extending the time taken for consensus.
Details
The validation check for the input data (byts) is performed twice:
BaseRunner.decide
method:Controller.StartNewInstance
method:Given that
BaseRunner.decide
callsController.StartNewInstance
, this results in the same validation check being performed twice on the same data.Suggestion
To optimize the consensus time, I propose removing one of these duplicate checks. My recommendation would be to keep the validation in the
Controller.StartNewInstance
method, as it seems more contextually appropriate for the responsibility of starting a new QBFT instance.The text was updated successfully, but these errors were encountered: