You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Details
The method SignedMessage.Validate is being called multiple times across different functions, which may lead to inefficiencies in processing.
The method SignedMessage.Validate is redundantly invoked in several places:
Within the Instance.BaseMsgValidation method:
// Instance.BaseMsgValidation methodiferr:=msg.Validate(); err!=nil {
returnerrors.Wrap(err, "invalid signed message")
}
Also in other functions such as isValidProposal, validSignedPrepareForHeightRoundAndRoot, validateCommit, and validRoundChangeForData. For example, in isValidProposal:
Details
The method SignedMessage.Validate is being called multiple times across different functions, which may lead to inefficiencies in processing.
The method
SignedMessage.Validate
is redundantly invoked in several places:Instance.BaseMsgValidation
method:isValidProposal
,validSignedPrepareForHeightRoundAndRoot
,validateCommit
, andvalidRoundChangeForData
. For example, inisValidProposal
:Proposed Solution
We can call
SignedMessage.Validate
only once at the beginning to avoid repeating it.The text was updated successfully, but these errors were encountered: