Skip to content

Conversation

@Hona
Copy link
Collaborator

@Hona Hona commented Nov 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 17, 2025 09:30
@Hona Hona requested review from kommander and msmps as code owners November 17, 2025 09:30
Copilot finished reviewing on behalf of Hona November 17, 2025 09:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test case to use a truly invalid path that works across all platforms. The old path /invalid/path/that/cannot/be/created could potentially be created with sufficient permissions on Unix-like systems, while the new path with a null byte character (\x00) is universally invalid across all operating systems.

Key changes:

  • Updated the test path to use a null byte character, which is invalid in all file systems

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Hona Hona changed the title fix(test): Make a truely global invalid path fix(tests): Fix tests to all pass on Windows Nov 17, 2025
@Hona Hona marked this pull request as draft November 17, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants