Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of BUG_ON macro #49

Open
bxatnarf opened this issue Aug 29, 2018 · 0 comments
Open

Reconsider use of BUG_ON macro #49

bxatnarf opened this issue Aug 29, 2018 · 0 comments

Comments

@bxatnarf
Copy link
Collaborator

kernel/popcorn/pcn_kmsg.c, for example, makes mutiple uses of the BUG_ON macro.
Linus is not a big fan of use of BUG_ON given that it forces a kernel panic. We should consider replacing calls BUG_ON with regular Linux-style sanity checks that signal errors via return values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant