You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CfbCipherMode is only used for PKCS1 private key encrypted byDES-EDE3-CFB. Suggest user switching to newer encryption method.
OfbCipherMode is not used anywhere inside the library.
CtrCipherMode is used for AesCipher. We can create a dedicated class AesCtrCipher, just like AesGcmCipher.
With all above concrete classes removed, we can remove the abstract class CipherMode. We can also remove AesCipherMode enum (renamed as BlockCipherMode in PR #1546) and use BCL's CipherMode enum.
Then AesCipher.BlockImpl can be removed, AesCipher.CtrImpl can be removed (moved to a dedicated class per above suggestion). AesCipher.BclImpl can be removed so that AesCipher can have a pure BCL implementation (without nested Impl classes)
So does the TripleDesCipher.
The text was updated successfully, but these errors were encountered:
We could consider dropping hand-written cipher modes in the library.
CbcCipherMode
will not be used anymore once PR Use System.Security.Cryptography for TripleDesCipher #1546 is merged.CfbCipherMode
is only used for PKCS1 private key encrypted byDES-EDE3-CFB. Suggest user switching to newer encryption method.OfbCipherMode
is not used anywhere inside the library.CtrCipherMode
is used forAesCipher
. We can create a dedicated classAesCtrCipher
, just likeAesGcmCipher
.With all above concrete classes removed, we can remove the abstract class
CipherMode
. We can also removeAesCipherMode
enum(renamed asand use BCL'sBlockCipherMode
in PR #1546)CipherMode
enum.Then
AesCipher.BlockImpl
can be removed,AesCipher.CtrImpl
can be removed (moved to a dedicated class per above suggestion).AesCipher.BclImpl
can be removed so thatAesCipher
can have a pure BCL implementation (without nestedImpl
classes)So does the
TripleDesCipher
.The text was updated successfully, but these errors were encountered: