Remove old target frameworks #10
Merged
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # install and configure sshd | ||
| apk add --no-cache openssh && \ | ||
| # install openssh-server-pam to allow for keyboard-interactive authentication | ||
| apk add --no-cache openssh-server-pam && \ | ||
| dos2unix /etc/ssh/* && \ |
There was a problem hiding this comment.
Without this line, tests did not work. Don't ask how long it took me :)
There was a problem hiding this comment.
I won't :p
I created them locally with LF and haven't cloned the repo since, which probably explains why they still have LF line endings here.
You may want to add a comment though (on all three dos2unix commands):
# make sure scripts and keys have unix (LF) line endingsThere was a problem hiding this comment.
I've added comments.
Now I think that it is very difficult to detect and maybe it would be worth adding a check in the library and showing a comment. Of course in other PR.
drieseng
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR relates with sshnet/SSH.NET#1109