Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project review #58

Open
abhi72181 opened this issue Jan 23, 2023 · 5 comments
Open

project review #58

abhi72181 opened this issue Jan 23, 2023 · 5 comments

Comments

@abhi72181
Copy link

No description provided.

@abhi72181
Copy link
Author

abhi72181 commented Jan 23, 2023

Screenshot (1149)

  1. In home page heading, some more padding or spacing would have improved the ui as compared to actual website(cronometer).
  2. login button is not working on mobile view.
  3. Home component should have been divided into multiple components to improve readability and reusibility.

@abhi72181
Copy link
Author

Screenshot (1150)
Screenshot (1151)

  1. signup ui needs improvement
    a) signup heading is having very little margin between them.
    b) your body type text is overflowing into confirm password input.
    c) on clicking view option both password and confirm password are changing at same time.
    d) after signup user data is not getting stored.

@abhi72181
Copy link
Author

abhi72181 commented Jan 23, 2023

Screenshot (1152)

In blog section:-

  1. skeleton loading is applied.
  2. search functionality is working but blog cards height is very much.

@abhi72181
Copy link
Author

Screenshot (1154)

In forums page:-

  1. chakra ui should have been used instead of normal input tag.
  2. search functionality is not working.

@abhi72181
Copy link
Author

Important points:-

  1. Didnot use redux thunk.
  2. Overall ui was good and responsive just need a little bit changes as mentioned above.
  3. some functionalities were not working, for example in forums page search functionality was not working, on signup user was not getting registered.
  4. User documentation was good but most of the commit messages were meaningless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant