Skip to content

Replace FhirPathFunction documentation string with a class#84

Merged
dogukan10 merged 5 commits intomasterfrom
fhir-path-function-data-types-enum
May 20, 2025
Merged

Replace FhirPathFunction documentation string with a class#84
dogukan10 merged 5 commits intomasterfrom
fhir-path-function-data-types-enum

Conversation

@camemre49
Copy link
Copy Markdown
Contributor

@camemre49 camemre49 commented Jan 21, 2025

The FhirPathFunction documentation was previously managed using a string containing all emojis, formats, and tags, which made it difficult to handle. This string has been replaced with a more organized data structure, and the corresponding annotation parser function is updated

Comment thread onfhir-path/src/main/scala/io/onfhir/path/AbstractFhirPathFunctionLibrary.scala Outdated
Comment thread onfhir-path/src/main/scala/io/onfhir/path/AbstractFhirPathFunctionLibrary.scala Outdated
@dogukan10
Copy link
Copy Markdown
Contributor

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from a49f23b to 5aa8412 Compare January 30, 2025 08:15
@camemre49
Copy link
Copy Markdown
Contributor Author

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

They can be replaced without any problem. return type and input type fields are not used on the web.

@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from 5aa8412 to 196c996 Compare January 30, 2025 11:31
@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from 196c996 to 126c3f2 Compare February 11, 2025 06:24
@dogukan10 dogukan10 force-pushed the fhir-path-function-data-types-enum branch from 126c3f2 to 09b753b Compare May 16, 2025 14:12
@dogukan10 dogukan10 force-pushed the fhir-path-function-data-types-enum branch from 09b753b to 7623e74 Compare May 16, 2025 14:12
@dogukan10 dogukan10 force-pushed the fhir-path-function-data-types-enum branch from 7623e74 to a190382 Compare May 16, 2025 14:58
@dogukan10 dogukan10 merged commit 2c0b845 into master May 20, 2025
1 of 2 checks passed
@dogukan10 dogukan10 deleted the fhir-path-function-data-types-enum branch May 20, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants