Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotifyWrite may be a poor implementation choice #23

Open
cnewman opened this issue Jan 8, 2019 · 0 comments
Open

NotifyWrite may be a poor implementation choice #23

cnewman opened this issue Jan 8, 2019 · 0 comments

Comments

@cnewman
Copy link
Member

cnewman commented Jan 8, 2019

Recently, I added a NotifyWrite function that allows writing into the srcSAXEventDispatcher context. The purpose is to allow for srcML archives to be modified by policies when required.

Writing to archives is something we need to be able to do, but it is possible that doing it through the context is not the best choice (i.e., maybe we should remove it from the context). Additionally, adding a NotifyWrite function is a detriment to speed in contexts where it is not required.

In the future, we should consider whether to keep NotifyWrite and where the XML writer should be housed in order to make this as fast and maintainable as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant