Fix a valgrind error and suppress compiler warnings

Author: robertgj

blkchol2.c

@@ -113,16 +113,21 @@ void cholonBlk(double *x, double *d, mwIndex m, const mwIndex ncols, const mwInd
    ------------------------------------------------------- */
     xkk = x[inz];
     if(xkk > lb[k]){ /* now xkk > 0 */
-      if((m>1) && (xkk < ub)){
+/* ------------------------------------------------------------
+   maxabs is a wrapper for the BLAS IDAMAX Fortran function.
+   IDAMAX finds the first element having maximum absolute
+   value in an array. Only call maxabs with m>1. 
+   ------------------------------------------------------------ */
+      if ((m>1) && (xkk < ub)){
         ubk = maxabs(x+inz+1,m-1) / maxu;
         if(xkk < ubk){
 /* ------------------------------------------------------------
    If we need to add on diagonal, store this in (skipIr, lb(k)).
    ------------------------------------------------------------ */
           skipIr[nskip++] = first + k;
-	  lb[k] = ubk - xkk;           /* amount added on diagonal */
-	  xkk = ubk;
-	}
+          lb[k] = ubk - xkk;           /* amount added on diagonal */
+          xkk = ubk;
+        }
       }
 /* --------------------------------------------------------------
    Set dk = xkk, lkk = 1 (for LDL').
@@ -170,7 +175,7 @@ void cholonBlk(double *x, double *d, mwIndex m, const mwIndex ncols, const mwInd
               INCLUDING THE DIAGONAL ENTRY.
      Lir    - Lir[0:nnz-1] ARE THE ROW INDICES OF THE NONZEROS
               OF THE FIRST COLUMN OF THE SUPERNODE.
-  OUTPUT PARAMETERS -
+  OUTPUT PARAMETERS - 
      irInv - On return, irInv[Lir[0:nnz-1]] = nnz:-1:1, so that
 		           Lir[nnz-irInv[i]]  == i
              The position of subscript "xij" is thus
@@ -314,7 +319,7 @@ void spadd(const mwIndex *xjjc, double *xnz, const mwIndex mj, const mwIndex nj,
   }
 }
 
-/* ************************************************************
+/* ************************************************************      
    PROCEDURE precorrect  -  Apply corrections from affecting supernode
       (skipping subnodes with non-positive diagonal) on supernodal
       diagonal block in L-factor.
@@ -520,7 +525,7 @@ mwIndex blkLDL(const mwIndex neqns, const mwIndex nsuper, const mwIndex *xsuper,
                                     length[k],xsuper[k],xsuper[k+1],
                                     relind,fwsiz,fwork)) == (mwIndex)-1 )
         return (mwIndex)-1;         /* fwsiz too small */
-    }
+    }	
 /* ------------------------------------------------------------
    DO DENSE CHOLESKY on the current supernode
    ------------------------------------------------------------ */

dpr1fact.c

@@ -365,7 +365,8 @@ char dodpr1fact(double *beta, mwIndex *perm, double *d, double t, const double *
    ------------------------------------------------------------ */
   else{
     psqrdep = 0.0;
-    for(i = 0, j = 0; dep[i] < m; i++)
+    j = 0;
+    for(i = 0; dep[i] < m; i++)
       if(psqr[dep[i]] > psqrdep){
         j = i;
         psqrdep = psqr[dep[i]];

install_sedumi.m

@@ -175,10 +175,6 @@ function install_sedumi( varargin )
       % whereas calling '-O' would result in gcc '-O1'.
       flags{end+1} = '-O2';
       flags{end+1} = '-DOCTAVE';
-      flags{end+1} = '-Werror';
-      flags{end+1} = '-Wall';
-      flags{end+1} = '-Wno-unused-variable';
-      flags{end+1} = '-Wno-unused-but-set-variable';
       if (ismac ())
         % Assume Homebrew (https://brew.sh/) installation.
         % https://stackoverflow.com/questions/50634727/dyld-library-not-loaded-usr-local-opt-openblas-lib-libopenblasp-r0-2-20-dylib

maxstep.m

@@ -50,7 +50,7 @@
     reltr = x(ix(1):ix(2)-1).*dx(ix(1):ix(2)-1)...
         - ddot(x(ix(2):ix(3)-1),dx,K.qblkstart);
     norm2 = reltr.^2 - tdet(dx,K).*auxx.tdet;
-    if norm2 > 0
+    if all(norm2 > 0)
         norm2 = sqrt(norm2);
     end
     mindxq = min( (reltr - norm2)./auxx.tdet);
@@ -64,4 +64,4 @@
     mindxs = minpsdeig(reldx, K);
     mindx = min(mindx, mindxs);
 end
-tp = 1 / max(-mindx, 1E-16);
+tp = 1 / max(-mindx, 1E-16);

psdframeit.c

@@ -107,9 +107,9 @@ void psdframeit(double *x, const double *frms, const double *lab,
 void mexFunction(const int nlhs, mxArray *plhs[],
   const int nrhs, const mxArray *prhs[])
 {
-  mwIndex i,lendiag, lenfull, lenud,qsize;
+  mwIndex i, lendiag, lenud, qsize;
   double *x, *fwork;
-  const double *lab,*frms;
+  const double *lab, *frms;
   mwIndex *sdpNL;
   coneK cK;
 /* ------------------------------------------------------------
@@ -126,7 +126,6 @@ void mexFunction(const int nlhs, mxArray *plhs[],
    ------------------------------------------------------------ */
   lenud = cK.rDim + cK.hDim;
   qsize = lenud + cK.hLen;
-  lenfull = cK.lpN +  cK.qDim + lenud;
   lendiag = cK.lpN + 2 * cK.lorN + cK.rLen + cK.hLen;
 /* ------------------------------------------------------------
    Get inputs lab,frms

sedumi.m

@@ -264,7 +264,11 @@
 if N*m<100000
     %Test if Ax=b is feasible at all
     %turn off the rank deficient warning for now
-    s = warning('off','MATLAB:singularMatrix');
+    if (exist ('OCTAVE_VERSION', 'builtin') == 5)
+      s = warning('off','Octave:singular-matrix');
+    else
+      s = warning('off','MATLAB:singularMatrix');
+    endif
     y=[A;b']\[zeros(N,1);1];
     if abs(y'*b-1) < 1e-10 && norm(A*y) < 1e-10
         %Infeasibility certificate found
@@ -778,8 +782,6 @@
     info.err(1)=norm(x'*(origcoeff.At)-(origcoeff.b)',2)/(1+normb);
     %Let us get rid of the K.f part, since the free variables don't make
     %any difference in the cone infeasibility.
-    %origcoeff.K.f=0;
-
     if origcoeff.K.f<length(origcoeff.c)
         %not all primal variables are free
         %     Primal cone infeasibility
@@ -788,14 +790,10 @@
         info.err(2)=max(0,-min(eigK(full(x(origcoeff.K.f+1:end)),tempK)/(1+normb)));
         %     Dual cone infeasibility
         info.err(4)=max(0,-min(eigK(full(s(origcoeff.K.f+1:end)),tempK)/(1+normc)));
-        
-    else
-        info.err(2)=0;
-        info.err(4)=0;
     end
     %     Dual infeasibility
-    info.err(3)=0.0; %s is not maintained explicitely
-        %     Relative duality gap
+    info.err(3)=0.0; % not maintained explicitly
+    %     Relative duality gap
     info.err(5)=(cx-by)/(1+abs(cx)+abs(by));
     %     Relative complementarity
     info.err(6)=xs/(1+abs(cx)+abs(by));

sqrtinv.c

@@ -95,7 +95,7 @@ void prpiqdivv(double *y,double *ypi, const double *q,const double *qpi,
 void mexFunction(const int nlhs, mxArray *plhs[],
   const int nrhs, const mxArray *prhs[])
 {
-  mwIndex i,k, nk, nksqr, lenud, lendiag, diagskip;
+  mwIndex k, nk, nksqr, lenud, lendiag, diagskip;
   double *y;
   const double *q,*v;
   coneK cK;

symfctmex.c

@@ -136,7 +136,6 @@ void mexFunction(const int nlhs, mxArray *plhs[],
     *invp, *colcnt;
   mxArray *L_FIELD;
   const char *LFieldnames[] = {"L", "perm", "xsuper"};
-  mwIndex *mwXjc, *mwXir, *mwLjc, *mwLir;
 /* ------------------------------------------------------------
    Check for proper number of arguments
    ------------------------------------------------------------ */

trydif.m

@@ -52,7 +52,7 @@
     halfxz = (x(ix(1):ix(2)-1).*z(ix(1):ix(2)-1)...
         + ddot(x(ix(2):ix(3)-1),z,K.qblkstart)) / 2;
     tmp = halfxz.^2 - detxz;
-    if tmp > 0
+    if all(tmp > 0)
         lab2q = halfxz + sqrt(tmp);
     else
         lab2q = halfxz;
@@ -69,4 +69,4 @@
     t = 0; 
     w = wIN; 
     wr = wrIN;
-end
+end

urotorder.c

@@ -313,7 +313,7 @@ void mexFunction(const int nlhs, mxArray *plhs[],
   const int nrhs, const mxArray *prhs[])
 {
   mxArray *myplhs[NPAROUT];
-  mwIndex i,j,k, nk, nksqr, lenud, sdplen, gnnz, inz, maxKs,maxKssqr, rgnnz, hgnnz;
+  mwIndex i, k, nk, nksqr, lenud, sdplen, gnnz, inz, maxKs, maxKssqr, rgnnz, hgnnz;
   const double *uOld, *permOld=NULL;
   double *u, *d, *gjcPr, *permPr, *fwork, *fworkpi;
   mwIndex *perm, *gjc;

vecsym.c

@@ -139,10 +139,8 @@ void vecsymPSD(double *y, const double *x,const mwIndex rsdpN,const mwIndex sdpN
 void mexFunction(const int nlhs, mxArray *plhs[],
   const int nrhs, const mxArray *prhs[])
 {
- mxArray *output_array[1], *Xk;
-
  coneK cK;
- mwIndex k, nk, nksqr, lqDim,lenfull;
+ mwIndex lqDim, lenfull;
  const double *x;
  double *y;
 

widelen.m

@@ -91,7 +91,7 @@
         halfxz = (xM(ix(1):ix(2)-1).*zM(ix(1):ix(2)-1)...
             + ddot(xM(ix(2):ix(3)-1),zM,K.qblkstart)) / 2;
         tmp = halfxz.^2 - detxz;
-        if tmp > 0
+        if all(tmp > 0)
             lab2q = halfxz + sqrt(tmp);
         else
             lab2q = halfxz;
@@ -124,4 +124,4 @@
     wr.alpha=alphaM;
     wr.delta=deltaM;
 end
-wr.desc = 1;       % always descent direction.
+wr.desc = 1;       % always descent direction.