-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Visibility Timeout #47
Comments
Hmm good question. Not something I had original thought about adding. I think it could be done as long as we have a way to ensure that the worker is still alive and processing, then the manager could bump the timeout continuously. We could also try threads on the worker but I am hesitant to mix that in. |
This would be awesome. Sometimes you have tasks of variable lengths and so it is hard to decide on a visibility timeout. If tasks could dynamically extend would solve a lot of issues. A simple approach might just be a method I think for a v1 it would be ok to say pyqs doesn't do anything too fancy, just exposes a method. |
…handling. When a task fails, immediately make it available again instead of waiting for visibility timeout. Fixes spulec#47
I opened a PR. The tests don't seem to run for me locally, and I didn't add more since I wanted to also make sure we agreed on this direction. |
Hello,
With SQS it is possible to continually bump the visibility timeout whilst working on a task. This allows a short retry time, but the ability to have jobs of potentially long length, as long as the worker keeps updating the timeout. Will PyQS support this?
The text was updated successfully, but these errors were encountered: